Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing newlines without JavaScript enabled #14

Closed
joesavage opened this issue Mar 9, 2016 · 3 comments
Closed

Missing newlines without JavaScript enabled #14

joesavage opened this issue Mar 9, 2016 · 3 comments
Labels

Comments

@joesavage
Copy link

Without JavaScript enabled, the code snippets are fairly unreadable. Screenshot attached.

screenshot

@kazzkiq kazzkiq added the bug label Mar 9, 2016
@kazzkiq
Copy link
Owner

kazzkiq commented Mar 9, 2016

As CodeFlask run on elements programmatically, there is no "easy way" to determine when a element will turn into a code editor without JavaScript enabled.

That being said, I think there should be a CSS class such as .CodeFlask__is-code that would make the code a little bit more readable in case JavaScript doesn't run. But this class would have to be added manually on the desired element.

@michaelspiss
Copy link
Contributor

A simple solution would be to add white-space: pre; to the .code-editor class (.code-window .code-editor in the css file). This way the line breaks will be shown even when JavaScript is disabled.

codeflask js simple code editor for awesome web pages

kazzkiq added a commit that referenced this issue Oct 7, 2016
@kazzkiq
Copy link
Owner

kazzkiq commented Oct 7, 2016

Fixed by #21

@kazzkiq kazzkiq closed this as completed Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@joesavage @kazzkiq @michaelspiss and others