Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add areaId, ariaLabelledby options #80

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

marcysutton
Copy link

This PR introduces two options: an areaId where you can provide an ID attribute for the textarea for binding with a native <label> element. While I was in there I also added an ariaLabelledby option to make it easier to use an existing element like a heading to name the textarea.

Markup case 1: areaId

<label for="thing1">Play with the code</label>
<textarea id="thing1"></textarea>

Markup case 2: ariaLabelledby

<h2 id="thing2">Play with the code</h2>
<textarea aria-labelledby="thing2"></textarea>

Developers can now choose either of those methods with the areaId and ariaLabelledby options, respectively.

Closes #78

@kazzkiq kazzkiq merged commit be2dfb5 into kazzkiq:master Jul 16, 2018
@kazzkiq
Copy link
Owner

kazzkiq commented Jul 17, 2018

Published in: v1.2.0

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants