Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proceeding timeout too short #44

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Dec 27, 2024

The default client invite timeout is currently 30 seconds for both the initiating and proceeding states. However, this duration is too short for some SIP providers.

To address this, we need to extend the timeout specifically for the proceeding state to prevent incorrect detection. Consider increasing it to 2 minutes.

@giangndm giangndm force-pushed the fix-proceeding-timeout-too-short branch from bd4f4ed to bb2069b Compare December 27, 2024 01:55
@kbalt
Copy link
Owner

kbalt commented Dec 28, 2024

As far as I can see, the timeout should only exist in the Calling state (confusingly called Init here), so calls to receive may only be be cancelled in the Init state. But since that could cause transactions to be stuck indefinitely, this seems good enough for me for now.

Thanks for noticing!

@kbalt kbalt merged commit 0d43015 into kbalt:main Dec 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants