Improve radiotap #517
Merged
Improve radiotap #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct endianness issues Support multi-byte present flags Handle misaligned flags fields
|
@obormot LGTM, feel free to merge at your convenience. |
Thanks! I'll try adding some more unit tests before merging. |
This was referenced Dec 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up on great work in PR #478 that had some issues with usage of
bytearrayand wasn't backward compatible with existing unit tests (which as I and others noticed contained some endianness issues).I've added the original unit tests back and adjusted the code to be backward compatible. Tested on both little and big endian architectures. This is by large just an incremental improvement/bugfix to radiotap module.