Release 0.1.4 (develop -> master) #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obsolete with switch to GHA
Remove build cruft
This is useful for temporary nodes where once the user has the data, the node is no longer needed, and the link to the data is expected to work once.
Add query param to delete after file stream
```
$ curl --cookie "kbase_session=$KBASE_CI_TOKEN" http://localhost:8080/node/06cc2b59-b33c-460a-8332-151a509b6d20/acl
{
"data": {
"delete": [
"057abd01-95db-4500-9541-8ce2a925c3e3"
],
"owner": "057abd01-95db-4500-9541-8ce2a925c3e3",
"public": {
"delete": false,
"read": false,
"write": false
},
"read": [
"057abd01-95db-4500-9541-8ce2a925c3e3"
],
"write": [
"057abd01-95db-4500-9541-8ce2a925c3e3"
]
},
"error": null,
"status": 200
}
$ curl --cookie "kbase_sessionx=$KBASE_CI_TOKEN" http://localhost:8080/node/06cc2b59-b33c-460a-8332-151a509b6d20/acl
{
"data": null,
"error": [
"User Unauthorized"
],
"status": 401
}
```
... to a reasonable character set. This avoids characters that may cause issues in mac, linux, and windows
Get auth token from cookie
Restrict filename and format strings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 90.49% 90.83% +0.34%
==========================================
Files 14 14
Lines 1998 2073 +75
==========================================
+ Hits 1808 1883 +75
Misses 157 157
Partials 33 33 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes reviewed in other PRs