Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove submodules #92

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Remove submodules #92

merged 1 commit into from
Apr 24, 2024

Conversation

MrCreosote
Copy link
Member

jars is no longer needed w/ Gradle
module_builder is no longer referenced anywhere in the project

jars is no longer needed w/ Gradle
module_builder is no longer referenced anywhere in the project
@MrCreosote MrCreosote requested a review from Xiangs18 April 23, 2024 20:24
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.19%. Comparing base (9b5c2fc) to head (a445c65).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #92   +/-   ##
==========================================
  Coverage      64.19%   64.19%           
  Complexity      1457     1457           
==========================================
  Files            101      101           
  Lines           5600     5600           
  Branches         575      575           
==========================================
  Hits            3595     3595           
  Misses          1775     1775           
  Partials         230      230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Xiangs18 Xiangs18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrCreosote MrCreosote merged commit a4701b9 into develop Apr 24, 2024
9 checks passed
@MrCreosote MrCreosote mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants