deploy: comments

.github/workflows/deploy.yml

@@ -17,13 +17,15 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: setup node
+      - name: Setup node
         uses: actions/setup-node@v4
         with:
           node-version: '20'
-      - name: Authenticate to Google Cloud
+      # After calling google's auth `firebase deploy` will use this auth
+      - name: Authenticate to Google Cloud/Firebase
         uses: google-github-actions/auth@v0.4.0
-        with:
+        with: 
+          # This is the service account secret stored in github secrets (setup by `firebase init hosting:github`)
           credentials_json: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_KWBLOG_1C958 }}'
       - name: Deploy
         shell: pwsh

README.md

@@ -21,5 +21,5 @@ It is hosted in [Google Firebase](https://firebase.google.com).
 
 - `npx firebase logout; npx firebase login;` might be needed if it's been a long time, even if firebase says it is already logged in.
 - to test with firebase before deploy: `npx firebase serve --only hosting`
-- to build the static site: `npm run build`
-- then to deploy: `npx firebase deploy`
+- to build the static site: `.\build`
+- to deploy: `.\build deploy`