move to fxhashmap for speed #409
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Can you share more specifics about how "bad" the memory consumption is? With the reduction in instruction counts does this lead to a material improvement in wall time? |
|
Memory issues was reported before: #383. With rustc repo, for example, over 8gb memory consumed before i cancelled run, only worked when i passed As for walltime, i'll try to check it on examples from issues. |
|
On repo from #380: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces few hashmaps to FxHashMaps, reducing instructions count for some workloads about x2. Memory consumption still bad (i mean, that it is currently bad, not that this pr changes this).