[bug] sqlite does not support --if-exists (fixes zenstruck#46)

kbond · Oct 8, 2020 · 4419a41 · 4419a41
1 parent 1138cf0
commit 4419a41
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -19,7 +19,6 @@ jobs:
           - 3306:3306
         options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
     strategy:
-      fail-fast: true
       matrix:
         php: [7.2, 7.3, 7.4]
         stability: [prefer-lowest, prefer-stable]

diff --git a/src/Test/DatabaseResetter.php b/src/Test/DatabaseResetter.php
@@ -39,11 +39,14 @@ public static function resetDatabase(KernelInterface $kernel): void
         $registry = $kernel->getContainer()->get('doctrine');
 
         foreach (self::connectionsToReset($registry) as $connection) {
-            self::runCommand($application, 'doctrine:database:drop', [
-                '--connection' => $connection,
-                '--if-exists' => true,
-                '--force' => true,
-            ]);
+            $dropParams = ['--connection' => $connection, '--force' => true];
+
+            if ('sqlite' !== $registry->getConnection($connection)->getDatabasePlatform()->getName()) {
+                // sqlite does not support "--if-exists" (ref: https://github.com/doctrine/dbal/pull/2402)
+                $dropParams['--if-exists'] = true;
+            }
+
+            self::runCommand($application, 'doctrine:database:drop', $dropParams);
 
             self::runCommand($application, 'doctrine:database:create', [
                 '--connection' => $connection,