Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it build against Qt 6 and KF 6 #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make it build against Qt 6 and KF 6 #20

wants to merge 1 commit into from

Conversation

kbroulik
Copy link
Owner

No description provided.

@kbroulik kbroulik force-pushed the kbroulik/qt6-prepare branch 3 times, most recently from 9252578 to b32f192 Compare December 18, 2023 17:24
alex1701c
alex1701c reviewed Dec 18, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
src/infocenter/kcm.h Outdated Show resolved Hide resolved
src/infocenter/kcm.cpp Outdated Show resolved Hide resolved
@alex1701c
Copy link
Contributor 


CMake Error at /home/user/kde/usr/lib/x86_64-linux-gnu/cmake/KF6KCMUtils/KF6KCMUtilsMacros.cmake:180 (message):
  Could not find any files in
  /home/user/kde/src/qalphacloud/src/infocenter/ui/*
Call Stack (most recent call first):
  /home/user/kde/usr/lib/x86_64-linux-gnu/cmake/KF6KCMUtils/KF6KCMUtilsMacros.cmake:174 (__kcmutils_target_qml_sources)
  src/infocenter/CMakeLists.txt:5 (kcmutils_add_qml_kcm)

This is a bit tricky regarding the KF5 compat. Maybe checking in a symlink works?

@kbroulik
Copy link
Owner Author

Can I not specify a path? I don’t like all this magic that is going on here, particularly if it breaks supporting both major versions.

@alex1701c
Copy link
Contributor

Maybe you could just install the files in kf5 manually, since you don't need any of the appstream generation or other KPackage logic. You only need to install the ui folder, because not even the metadata.json is needed for KPackage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex1701c alex1701c alex1701c left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbroulik @alex1701c