handle filesystem errors in cli

kbrsh · Dec 23, 2019 · 253e22d · 253e22d
1 parent 6170ffc
commit 253e22d
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 7 deletions.
diff --git a/packages/moon-cli/dist/moon-cli.js b/packages/moon-cli/dist/moon-cli.js
@@ -125,9 +125,15 @@
 	function install(name, archivePath) {
 		var targetPath = path.join(process.cwd(), name);
 		exec("mkdir " + targetPath, function (error) {
-			if (error) logError(error);
+			if (error !== null) {
+				logError("Failed directory creation.\n\nAttempted to create directory:\n\t" + targetPath + "\n\nReceived error:\n\t" + error + "\n\nExpected successful directory creation.");
+			}
+
 			exec("tar -xzf " + archivePath + " -C " + targetPath + " --strip=1", function (error) {
-				if (error) logError(error);
+				if (error !== null) {
+					logError("Failed archive extraction.\n\nAttempted to extract archive to target:\n\t" + archivePath + " -> " + targetPath + "\n\nReceived error:\n\t" + error + "\n\nExpected successful archive extraction.");
+				}
+
 				log("installed", targetPath);
 				clean(name, archivePath, targetPath);
 			});
@@ -136,7 +142,10 @@
 
 	function clean(name, archivePath, targetPath) {
 		fs.unlink(archivePath, function (error) {
-			if (error) logError(error);
+			if (error !== null) {
+				logError("Failed archive deletion.\n\nAttempted to delete archive:\n\t" + archivePath + "\n\nReceived error:\n\t" + error + "\n\nExpected successful archive deletion.");
+			}
+
 			log("cleaned", archivePath);
 			processDirectory(name, targetPath, targetPath);
 			log("created", "application \x1B[36m" + name + "\x1B[0m\n\nTo start, run:\n\tcd " + name + "\n\tnpm install\n\tnpm run dev");

diff --git a/packages/moon-cli/dist/moon-cli.min.js b/packages/moon-cli/dist/moon-cli.min.js
diff --git a/packages/moon-cli/src/index.js b/packages/moon-cli/src/index.js
@@ -147,10 +147,30 @@ function install(name, archivePath) {
 	const targetPath = path.join(process.cwd(), name);
 
 	exec(`mkdir ${targetPath}`, error => {
-		if (error) logError(error);
+		if (error !== null) {
+			logError(`Failed directory creation.
+
+Attempted to create directory:
+	${targetPath}
+
+Received error:
+	${error}
+
+Expected successful directory creation.`);
+		}
 
 		exec(`tar -xzf ${archivePath} -C ${targetPath} --strip=1`, error => {
-			if (error) logError(error);
+			if (error !== null) {
+				logError(`Failed archive extraction.
+
+Attempted to extract archive to target:
+	${archivePath} -> ${targetPath}
+
+Received error:
+	${error}
+
+Expected successful archive extraction.`);
+			}
 
 			log("installed", targetPath);
 			clean(name, archivePath, targetPath);
@@ -160,7 +180,17 @@ function install(name, archivePath) {
 
 function clean(name, archivePath, targetPath) {
 	fs.unlink(archivePath, error => {
-		if (error) logError(error);
+		if (error !== null) {
+			logError(`Failed archive deletion.
+
+Attempted to delete archive:
+	${archivePath}
+
+Received error:
+	${error}
+
+Expected successful archive deletion.`);
+		}
 
 		log("cleaned", archivePath);
 		processDirectory(name, targetPath, targetPath);