remove wrong map in empty loop

kbrsh · Jun 13, 2019 · 749adf3 · 749adf3
1 parent dd31f99
commit 749adf3
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 6 deletions.
diff --git a/packages/moon/dist/moon.js b/packages/moon/dist/moon.js
@@ -1237,8 +1237,12 @@
 			} // Execute the views of the children.
 
 
-			for (var i = 0; i < nodeChildren.length; i++) {
-				nodes.push(nodeChildren[i]);
+			var nodeChildrenLength = nodeChildren.length;
+
+			if (nodeChildrenLength !== 0) {
+				for (var i = 0; i < nodeChildrenLength; i++) {
+					nodes.push(nodeChildren[i]);
+				}
 			}
 
 			if (nodes.length === 0) {

diff --git a/packages/moon/dist/moon.min.js b/packages/moon/dist/moon.min.js
diff --git a/packages/moon/src/executor/executor.js b/packages/moon/src/executor/executor.js
@@ -100,8 +100,12 @@ function executeView(nodes) {
 		}
 
 		// Execute the views of the children.
-		for (let i = 0; i < nodeChildren.length; i++) {
-			nodes.push(nodeChildren[i]);
+		const nodeChildrenLength = nodeChildren.length;
+
+		if (nodeChildrenLength !== 0) {
+			for (let i = 0; i < nodeChildrenLength; i++) {
+				nodes.push(nodeChildren[i]);
+			}
 		}
 
 		if (nodes.length === 0) {

diff --git a/packages/moon/test/performance/list.js b/packages/moon/test/performance/list.js
@@ -22,6 +22,7 @@ function element(parent) {
 		attributes: [{name: "id", value: "test"}],
 		parentNode: parent === undefined ? element(true) : {},
 		appendChild: function() {},
+		removeChild: function() {},
 		replaceChild: function() {}
 	};
 }
@@ -45,5 +46,6 @@ Moon({
 });
 
 for (var i = 0; i < 10000; i++) {
-	Moon.set({ list: Moon.get.list.concat([7]) });
+	//Moon.set({ list: Moon.get.list.concat([7]) });
+	Moon.set({ list: [] });
 }