Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AbstractApi::post() #383

Merged
merged 30 commits into from
Feb 27, 2024
Merged

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Feb 19, 2024

See #372

Requires #381

@Art4 Art4 added this to the v2.6.0 milestone Feb 19, 2024
@Art4 Art4 self-assigned this Feb 19, 2024
Copy link

gitguardian bot commented Feb 19, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (3f6474f) to head (c516448).

Additional details and impacted files
@@             Coverage Diff              @@
##               v2.x     #383      +/-   ##
============================================
+ Coverage     97.71%   98.18%   +0.47%     
- Complexity      589      601      +12     
============================================
  Files            29       29              
  Lines          1707     1767      +60     
============================================
+ Hits           1668     1735      +67     
+ Misses           39       32       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4 Art4 requested a review from kbsali February 26, 2024 15:21
@Art4 Art4 marked this pull request as ready for review February 26, 2024 15:22
Copy link
Owner

@kbsali kbsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

@Art4 Art4 merged commit cffff37 into kbsali:v2.x Feb 27, 2024
12 checks passed
@Art4 Art4 deleted the deprecate-abstractapi-post branch February 27, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants