Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CS errors #402

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fix CS errors #402

merged 2 commits into from
Jun 26, 2024

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Jun 26, 2024

PHP-CS-Fixer has updated the PER-CS2.0 ruleset. It will now add trailing comma in multiline after parameters and match. This is only supported since PHP 8.0. So I've added a restriction for this rule to support PHP 7.4 for now. After dropping support for PHP 7.4 this rule restriction should be removed.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (ae384f0) to head (fecc1bf).

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x     #402   +/-   ##
=========================================
  Coverage     98.47%   98.47%           
  Complexity      609      609           
=========================================
  Files            29       29           
  Lines          1840     1841    +1     
=========================================
+ Hits           1812     1813    +1     
  Misses           28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4 Art4 added this to the v2.7.0 milestone Jun 26, 2024
@Art4 Art4 requested a review from kbsali June 26, 2024 07:35
Copy link
Owner

@kbsali kbsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 i like that :)

@Art4 Art4 merged commit ca87f14 into kbsali:v2.x Jun 26, 2024
12 checks passed
@Art4 Art4 deleted the fix-cs-errors branch June 26, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants