Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate all Redmine\Api\*::getIdBy...() methods #422

Merged

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Jul 8, 2024

Closes #417.

Todo

  • Deprecate CustomField::getIdByName()
  • Deprecate IssueCategory::getIdByName()
  • Deprecate IssueStatus::getIdByName()
  • Deprecate Project::getIdByName()
  • Deprecate TimeEntryActivity::getIdByName()
  • Deprecate Tracker::getIdByName()
  • Deprecate User::getIdByUsername()
  • Deprecate Version::getIdByName()

@Art4 Art4 added this to the v2.7.0 milestone Jul 8, 2024
@Art4 Art4 self-assigned this Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (a4da285) to head (b11e318).

Additional details and impacted files
@@             Coverage Diff              @@
##               v2.x     #422      +/-   ##
============================================
+ Coverage     98.57%   98.60%   +0.03%     
- Complexity      649      657       +8     
============================================
  Files            29       29              
  Lines          1959     2001      +42     
============================================
+ Hits           1931     1973      +42     
  Misses           28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4 Art4 requested a review from kbsali July 9, 2024 11:34
@Art4 Art4 marked this pull request as ready for review July 9, 2024 11:34
@Art4 Art4 merged commit e3de799 into kbsali:v2.x Jul 9, 2024
12 checks passed
@Art4 Art4 deleted the 417-deprecate-all-redmineapigetidbyname-methods branch July 9, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate all Redmine\Api\*::getIdByName() methods
2 participants