-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support primitive java types #299
Merged
ledsoft
merged 6 commits into
kbss-cvut:development
from
luxbe:feature/297-primitive-java-attributes
Dec 17, 2024
Merged
Support primitive java types #299
ledsoft
merged 6 commits into
kbss-cvut:development
from
luxbe:feature/297-primitive-java-attributes
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OWL DatatypeTransformer
luxbe
force-pushed
the
feature/297-primitive-java-attributes
branch
from
December 16, 2024 15:57
89b0f05
to
4a30c29
Compare
…e method - converts Wrapper classes (e.g. Integer.class) to their corresponding primitive counterparts (e.g. int.class)
…elds - remove MetamodelInitializationException thrown in ClassFieldMetamodelProcessor - check if Wrapper type can be converted to primitive type in DataPropertyFieldStrategy
luxbe
force-pushed
the
feature/297-primitive-java-attributes
branch
from
December 17, 2024 13:20
6fb4725
to
c509e48
Compare
ledsoft
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small suggestions.
datatype/src/main/java/cz/cvut/kbss/jopa/datatype/DatatypeTransformer.java
Outdated
Show resolved
Hide resolved
jopa-impl/src/main/java/cz/cvut/kbss/jopa/oom/DataPropertyFieldStrategy.java
Outdated
Show resolved
Hide resolved
jopa-impl/src/main/java/cz/cvut/kbss/jopa/oom/converter/CharacterConverter.java
Outdated
Show resolved
Hide resolved
...-integration-tests/src/main/java/cz/cvut/kbss/jopa/test/runner/RetrieveOperationsRunner.java
Outdated
Show resolved
Hide resolved
datatype/src/main/java/cz/cvut/kbss/jopa/datatype/DatatypeTransformer.java
Outdated
Show resolved
Hide resolved
ledsoft
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #297 by adding support for primitive Java types like
int
,short
,boolean
and more.char
is unsupported, because XSD does not include a char datatype. We could however probably implement it by mapping it toXSD.STRING
null
. I think this behavior is valid, because this state is only reachable if the database is mutated directly, but I would love to add a test for this - where would be a good place to do so?