Add support for NLBs to AWS Ingress #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pst
requested changes
Nov 4, 2021
pst
approved these changes
Nov 6, 2021
|
Thanks for the contribution @markszabo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running istio and changing the ingress from classic ELB to NLB. This breaks this module, as
aws_elb_hosted_zone_iddoesn't support NLB: hashicorp/terraform-provider-aws#7988This PR implements the workaround described in the issue with an optional flag.
We could also just use the workaround for all cases, but it seems to me that
aws_lbdoesn't support classic ELBs: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb