Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kustomize dependencies #134

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Update kustomize dependencies #134

merged 1 commit into from
Oct 1, 2021

Conversation

willthames
Copy link
Contributor

Migrate to latest kustomize/api (v0.10.0) and latest
kustomize/kyaml (v0.12.0)

@willthames
Copy link
Contributor Author

This addresses #126 but there's one failing test remaining - as I suspect I'm on a diametrically opposing timezone I'll leave this here for my overnight and look at it again in the morning

@willthames willthames mentioned this pull request Sep 30, 2021
Merged
@pst
Copy link
Member

pst commented Sep 30, 2021

The main reason that blocked updating the Kustomize version in the provider was the issue with kyaml not supporting anchors. But this should be resolved according to upstream kubernetes-sigs/kustomize#3675

Happy to merge this as soon as tests pass.

@pst pst mentioned this pull request Sep 30, 2021
Closed
@willthames
Update kustomize dependencies
0f26b21 
Migrate to latest kustomize/api (v0.10.0) and latest
kustomize/kyaml (v0.12.0)
@willthames willthames marked this pull request as ready for review October 1, 2021 01:01
@willthames
Copy link
Contributor Author

The remaining test appears to just be a change in the result of the hash that kustomize generates for a secret.

All tests now pass

@willthames willthames mentioned this pull request Oct 1, 2021
Closed
@pst
Copy link
Member

pst commented Oct 1, 2021

Yeah the hash is based on the content of the secret or configMap and if that changes, e.g. a line ending is removed the entire hash changes. I'll test this, merge it and fix the hash.

Thanks for your work on this.

@willthames
Copy link
Contributor Author

willthames commented Oct 1, 2021 •
edited
Loading

@pst - the hash is fixed in this PR with 0f26b21 - all tests pass locally for me

@pst pst merged commit f90ba7f into kbst:master Oct 1, 2021
@pst
Copy link
Member

pst commented Oct 1, 2021

I can confirm, tests pass just fine. Thanks again.

@willthames willthames deleted the update-resid branch October 1, 2021 09:57
@Aankhen Aankhen mentioned this pull request Oct 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willthames @pst