Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kustomize to v5.0.1 #227

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Upgrade kustomize to v5.0.1 #227

merged 1 commit into from
Mar 30, 2023

Conversation

olfway
Copy link
Contributor

@olfway olfway commented Mar 23, 2023

Add support for new Helm fields: additionalValuesFiles, skipTests, apiVersions and nameTemplate

Fixes: #223

Add support for new Helm fields: additionalValuesFiles, skipTests, apiVersions and nameTemplate
Copy link
Member

@pst pst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions. For my understanding, I get the version bump, but I am not sure why the changes to the tests are necessary. Is there some upstream breaking change regarding this?

@olfway
Copy link
Contributor Author

olfway commented Mar 29, 2023

Yes, I just bumped dependencies and after that fixed broken tests

In one case kustomize added creationTimestamp: null field

Other changes is because patches, as I understand, was for a long time an alias for patchesStrategicMerge
And in 5.0 version both patchesJson6902 and patchesStrategicMerge are deprecated in favour of newer patches:
kubernetes-sigs/kustomize#5052 (comment)

So I converted patches (as alias to patchesStrategicMerge) to a newer patches

In one case I had to split files with patches into two separate files because newer patches doesn't support multiple patches in one file yet:
kubernetes-sigs/kustomize#5049

@pst
Copy link
Member

pst commented Mar 29, 2023

Thanks for the background, I'm a bit concerned that this upstream change might break the kustomization_overlay's use of patches too. Although I would have expected a test to fail if it did. At the very least I'd have to document it in the release notes.

I will look into this as soon as I can. I am currently busy with a big release for the Kubestack framework. So it may take a few days until I find the time.

@pst
Copy link
Member

pst commented Mar 30, 2023

During breakfast, I suddenly thought, wait, my concern about a breaking change doesn't apply. Because kustomization_resource in the Terraform schema only ever supported lists of objects, not the list of strings that Kustomization YAML also supported. So from the provider's perspective this is not a breaking change. I'll merge and see if I find time to test a release candidate.

Thanks for the contribution again!

@pst pst merged commit 4f55a58 into kbst:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade kustomize/api and kustomize/kyaml
3 participants