-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add api_versions and kube_version to helm_charts block #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I take more helm stuff that I don't use and don't understand into the code base, I must require it to include tests. Otherwise, I can't know if any future work I do breaks it or not. I'm sure you will understand.
ad53ade
to
d71d4c2
Compare
d71d4c2
to
8437240
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests I asked for. I'll work on cutting a release this weekend so you can use your contribution more easily.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [kustomization](https://registry.terraform.io/providers/kbst/kustomization) ([source](https://github.com/kbst/terraform-provider-kustomization)) | required_provider | patch | `0.9.5` -> `0.9.6` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kbst/terraform-provider-kustomization (kustomization)</summary> ### [`v0.9.6`](https://github.com/kbst/terraform-provider-kustomization/releases/tag/v0.9.6) [Compare Source](https://github.com/kbst/terraform-provider-kustomization/compare/v0.9.5...v0.9.6) #### What's Changed - Use kustomize_options as block in example by [@​torvitas](https://github.com/torvitas) in [kbst/terraform-provider-kustomization#247 - updating Go and deps to fix CVEs by [@​valeriodelsarto](https://github.com/valeriodelsarto) in [kbst/terraform-provider-kustomization#249 - Add api_versions and kube_version to helm_charts block by [@​FlxPeters](https://github.com/FlxPeters) in [kbst/terraform-provider-kustomization#253 #### New Contributors - [@​torvitas](https://github.com/torvitas) made their first contribution in [kbst/terraform-provider-kustomization#247 - [@​valeriodelsarto](https://github.com/valeriodelsarto) made their first contribution in [kbst/terraform-provider-kustomization#249 - [@​FlxPeters](https://github.com/FlxPeters) made their first contribution in [kbst/terraform-provider-kustomization#253 **Full Changelog**: kbst/terraform-provider-kustomization@v0.9.5...v0.9.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/lambchop4prez/network). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
There are some field mappings missing the
helm_charts
block.This MR adds the
api_versions
list and thekube_version
field in order to provide this fields to an Helm chart using the$.Capabilities.APIVersions.Has
checks.Refference: