Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add litedebug mode #124

Merged
merged 3 commits into from
Aug 8, 2023
Merged

add litedebug mode #124

merged 3 commits into from
Aug 8, 2023

Conversation

junnmm
Copy link
Collaborator

@junnmm junnmm commented Aug 4, 2023

Add a new litedebug to --http.api option. And expose only selected methods from the tracer API.

TODO:

  • initial implementation
  • Review by @0xcary
  • Add hive test cases
    • enable "litedebug" without "debug".
    • enable both "litedebug" and "debug". (methods from both modules are expected to be merged )

@junnmm junnmm requested a review from 0xcary August 6, 2023 08:59
@junnmm junnmm marked this pull request as ready for review August 7, 2023 07:58
Copy link
Collaborator

@0xcary 0xcary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junnmm junnmm changed the title WIP: add lightdebug mode add litedebug mode Aug 7, 2023
@viaweb3
Copy link

viaweb3 commented Aug 7, 2023

What will happen if someone enable both debug and litedebug options?

@junnmm
Copy link
Collaborator Author

junnmm commented Aug 7, 2023 via email

@viaweb3 viaweb3 merged commit 0cec1af into kcc-community:kcc Aug 8, 2023
5 checks passed
@0xcary
Copy link
Collaborator

0xcary commented Aug 8, 2023

What will happen if someone enable both debug and litedebug options?

I think it will work fine.

@junnmm junnmm mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants