Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify pull cli #103

Merged
merged 4 commits into from
Jul 4, 2024
Merged

feat: unify pull cli #103

merged 4 commits into from
Jul 4, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Jul 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re kcl-lang/kpm#289

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added the enhancement New feature or request label Jul 4, 2024
@zong-zhe zong-zhe requested a review from Peefy July 4, 2024 12:45
@zong-zhe zong-zhe self-assigned this Jul 4, 2024
@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9794575549

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.212%

Totals Coverage Status
Change from base Build 9663137069: 0.0%
Covered Lines: 130
Relevant Lines: 359

💛 - Coveralls

Signed-off-by: zongz <zongzhe1024@163.com>
cmd/kcl/commands/mod_pull.go Outdated Show resolved Hide resolved
cmd/kcl/commands/mod_pull.go Outdated Show resolved Hide resolved
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9794872156

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.212%

Totals Coverage Status
Change from base Build 9663137069: 0.0%
Covered Lines: 130
Relevant Lines: 359

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9794949697

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.212%

Totals Coverage Status
Change from base Build 9663137069: 0.0%
Covered Lines: 130
Relevant Lines: 359

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 3abbfac into kcl-lang:main Jul 4, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants