Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name the registry a special kcl-registry instead of a common registry. #121

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

liangyuanpeng
Copy link
Contributor

follow up kcl-lang/kpm#421

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10210386488

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 14.19%

Totals Coverage Status
Change from base Build 10209430385: 0.0%
Covered Lines: 85
Relevant Lines: 599

💛 - Coveralls

@Peefy
Copy link
Contributor

Peefy commented Aug 2, 2024

Good Job! LGTM!

@Peefy Peefy merged commit ee196e2 into kcl-lang:main Aug 2, 2024
10 checks passed
@liangyuanpeng liangyuanpeng deleted the rename_registry branch August 2, 2024 06:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants