Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rename and no_sum_check flags for kcl mod command #84

Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 22, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: add rename and no_sum_check flags for kcl mod command

Signed-off-by: peefy <xpf6677@163.com>
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9188830863

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.209%

Totals Coverage Status
Change from base Build 9158483049: 0.0%
Covered Lines: 128
Relevant Lines: 335

💛 - Coveralls

@Peefy Peefy merged commit 0496002 into kcl-lang:main May 22, 2024
8 of 9 checks passed
@Peefy Peefy deleted the feat-kcl-mod-rename-and-no-sum-check-flag branch May 22, 2024 09:37
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants