Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tini to support arm64 image #98

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Conversation

ekirmayer
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #97

2. What is the scope of this PR (e.g. component or file name):

Dockerfile

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Update the Dockerfile to to download the tini version of the specific target environment

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • [x ] Manual test (add detailed scripts or steps below)
  • Other

Test in K8s cluster the the image can start without execution error due to architecture

Copy link

github-actions bot commented Jun 16, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Signed-off-by: ekirmayer <ekirmayer@hotmail.com>
@coveralls
Copy link

coveralls commented Jun 16, 2024

Pull Request Test Coverage Report for Build 9534536893

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.212%

Totals Coverage Status
Change from base Build 9478092127: 0.0%
Covered Lines: 130
Relevant Lines: 359

💛 - Coveralls

@ekirmayer
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Peefy added a commit to kcl-lang/cla.db that referenced this pull request Jun 16, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit dd4d72b into kcl-lang:main Jun 16, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docker] Tini install amd in ARM image
3 participants