Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all service.KclvmService methods to NativeServiceClient #252

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

bozaro
Copy link
Contributor

@bozaro bozaro commented Mar 11, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/native/client.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Add all service.KclvmService methods to NativeServiceClient.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link

github-actions bot commented Mar 11, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM!

@coveralls
Copy link

coveralls commented Mar 11, 2024

Pull Request Test Coverage Report for Build 8231441790

Details

  • 11 of 65 (16.92%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 62.172%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/native/client.go 11 65 16.92%
Files with Coverage Reduction New Missed Lines %
pkg/native/client.go 3 38.53%
Totals Coverage Status
Change from base Build 8227969953: -0.6%
Covered Lines: 3126
Relevant Lines: 5028

💛 - Coveralls

@Peefy
Copy link
Contributor

Peefy commented Mar 11, 2024

Hello @bozaro Please sign the DCO and CLA. Thank you for the contribution. Code LGTM!

Signed-off-by: Artem V. Navrotskiy <bozaro@yandex.ru>
@bozaro
Copy link
Contributor Author

bozaro commented Mar 11, 2024

I have read the CLA Document and I hereby sign the CLA

Peefy added a commit to kcl-lang/cla.db that referenced this pull request Mar 11, 2024
@Peefy Peefy merged commit b30cc1a into kcl-lang:main Mar 11, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
3 participants