Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more APIs for the KCL result #263

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 21, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: add more APIs for the KCL result

2. What is the scope of this PR (e.g. component or file name):

  • pkg/kcl/api.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • pkg/kcl/api_test.go

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy requested a review from zong-zhe March 21, 2024 07:19
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8371096301

Details

  • 24 of 70 (34.29%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 61.525%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kcl/api.go 24 70 34.29%
Totals Coverage Status
Change from base Build 8355231588: -0.4%
Covered Lines: 3163
Relevant Lines: 5141

💛 - Coveralls

@Peefy Peefy merged commit ad5789f into kcl-lang:main Mar 21, 2024
6 checks passed
@Peefy Peefy deleted the add-more-api-for-kcl-result branch March 21, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
3 participants