Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove kpm deps outof kcl-go and reduce the 3rdparty deps size #360

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 30, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #359

refactor: remove kpm deps outof kcl-go and reduce the 3rdparty deps size

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10158953313

Details

  • 35 of 52 (67.31%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 32.307%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/tools/gen/gendoc.go 0 3 0.0%
pkg/tools/gen/genopenapi.go 35 49 71.43%
Totals Coverage Status
Change from base Build 10138345203: 0.08%
Covered Lines: 5602
Relevant Lines: 17340

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit bdacfd8 into kcl-lang:main Jul 30, 2024
11 checks passed
@Peefy Peefy deleted the refactor-kcl-kpm-deps branch July 30, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants