New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhancement kcl import go struct with schema name and doc field #367

Merged

Peefy merged 1 commit into kcl-lang:main from Peefy:enhance-kcl-import-go-struct

Aug 12, 2024

Contributor

Peefy commented Aug 12, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

N
Y

feat: enhancement kcl import go struct with schema name and doc field


          feat: enhancement kcl import go struct with schema name and doc field

1dd374f

Signed-off-by: peefy <xpf6677@163.com>

zong-zhe approved these changes

View reviewed changes

Contributor

zong-zhe left a comment

LGTM

coveralls commented Aug 12, 2024

Pull Request Test Coverage Report for Build 10346554617

Details

4 of 6 (66.67%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 32.363%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/tools/gen/genkcl_jsonschema.go	1	3	33.33%

Totals
Change from base Build 10264036528:	0.05%
Covered Lines:	5612
Relevant Lines:	17341

💛 - Coveralls

Peefy merged commit 85bd62a into kcl-lang:main

11 checks passed

Peefy deleted the enhance-kcl-import-go-struct branch

August 12, 2024 06:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet