Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: additional property and item property pattern #81

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Dec 19, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: additional property and item property pattern

2. What is the scope of this PR (e.g. component or file name):

  • pkg/swagger/generator/model.go
  • pkg/swagger/generator/template_repo.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • pkg/kube_resource/generator/testdata/additional_properties_pattern/crd.golden.yaml

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy requested a review from zong-zhe December 19, 2023 07:48
Copy link

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit cdaa48b into kcl-lang:main Dec 19, 2023
5 checks passed
@Peefy Peefy deleted the fix-additional-property-pattern branch December 19, 2023 07:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants