Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add github icon #51

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat: add github icon #51

merged 1 commit into from
Nov 12, 2024

Conversation

slusy
Copy link
Contributor

@slusy slusy commented Nov 12, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #50

2. What is the scope of this PR (e.g. component or file name):

/src/index.html

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Add GitHub icon in the upper right corner

image #### 4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kcl-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:21am

@Peefy
Copy link
Contributor

Peefy commented Nov 12, 2024

Thank you!

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 084eff8 into kcl-lang:main Nov 12, 2024
3 of 6 checks passed
@slusy slusy deleted the feat/add-github-icon branch November 12, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add a GitHub Icon in the upper right corner to navigate to the GitHub repository
2 participants