Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dead code in the assembler. #531

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 26, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

refactor: remove dead code in the assembler.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

All integraition grammar tests.

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added this to the v0.5.0 Release milestone Apr 26, 2023
@Peefy Peefy requested review from NeverRaR and zong-zhe April 26, 2023 09:37
@coveralls
Copy link
Collaborator

coveralls commented Apr 26, 2023

Pull Request Test Coverage Report for Build 4807188889

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-20.8%) to 67.171%

Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 50.0%
Totals Coverage Status
Change from base Build 4795695340: -20.8%
Covered Lines: 29738
Relevant Lines: 44272

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 00d7e6a into kcl-lang:main Apr 26, 2023
@Peefy Peefy deleted the remove-assebler-dead-code branch April 26, 2023 09:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants