✨ Add ClusterAwareBuilderWithOptions to the wrapper

[fgiloux]

This adds a wrapper ClusterAwareBuilderWithOptions to the BuilderWithOptions function of controller-runtime. This wrapper calls
NewClusterAwareCache instead of New.
This allows the use of cache options by cluster aware controllers.

Fixes #25

Signed-off-by: Frederic Giloux fgiloux@redhat.com

[openshift-ci]

Hi @fgiloux. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fgiloux]

As we don't have better documentation today and operator authors rely on the controller-runtime-example for guidance I would propose to add 2 lines of comment to its main.go after this PR. Something like

// If a custom cache is created it needs to be cluster aware. For the purpose
// kcp.ClusterAwareBuilderWithOptions can be used instead of cache.BuilderWithOptions
mgr, err = kcp.NewClusterAwareManager(cfg, options)

What do you think?

[fgiloux]

@varshaprasad96 @stevekuznetsov would you mind reviewing this PR?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [ncdc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ncdc]

/ok-to-test

[varshaprasad96]

/lgtm
/retest