openshift-goimports tool doesn't build on macOS

[jpeach]

Describe the bug

The build wraps various helper tools in build scripts that don't seem to work reliably in all build environments.

To Reproduce

$ make imports
GOBIN=/Users/jpeach/upstream/kcp/hack/tools ./hack/go-install.sh github.com/coreydaley/openshift-goimports openshift-goimports b92214262c6ce8598aefdee87aae6b8cf1a9fc86
go: creating new go.mod: module fake/mod
# golang.org/x/sys/unix
/Users/jpeach/go/pkg/mod/golang.org/x/sys@v0.0.0-20201109165425-215b40eba54c/unix/syscall_darwin.1_13.go:29:3: //go:linkname must refer to declared function or variable
/Users/jpeach/go/pkg/mod/golang.org/x/sys@v0.0.0-20201109165425-215b40eba54c/unix/zsyscall_darwin_arm64.1_13.go:27:3: //go:linkname must refer to declared function or variable
/Users/jpeach/go/pkg/mod/golang.org/x/sys@v0.0.0-20201109165425-215b40eba54c/unix/zsyscall_darwin_arm64.1_13.go:40:3: //go:linkname must refer to declared function or variable
/Users/jpeach/go/pkg/mod/golang.org/x/sys@v0.0.0-20201109165425-215b40eba54c/unix/zsyscall_darwin_arm64.go:28:3: //go:linkname must refer to declared function or variable
/Users/jpeach/go/pkg/mod/golang.org/x/sys@v0.0.0-20201109165425-215b40eba54c/unix/zsyscall_darwin_arm64.go:43:3: //go:linkname must refer to declared function or variable
/Users/jpeach/go/pkg/mod/golang.org/x/sys@v0.0.0-20201109165425-215b40eba54c/unix/zsyscall_darwin_arm64.go:59:3: //go:linkname must refer to declared function or variable
/Users/jpeach/go/pkg/mod/golang.org/x/sys@v0.0.0-20201109165425-215b40eba54c/unix/zsyscall_darwin_arm64.go:75:3: //go:linkname must refer to declared function or variable
/Users/jpeach/go/pkg/mod/golang.org/x/sys@v0.0.0-20201109165425-215b40eba54c/unix/zsyscall_darwin_arm64.go:90:3: //go:linkname must refer to declared function or variable
/Users/jpeach/go/pkg/mod/golang.org/x/sys@v0.0.0-20201109165425-215b40eba54c/unix/zsyscall_darwin_arm64.go:105:3: //go:linkname must refer to declared function or variable
/Users/jpeach/go/pkg/mod/golang.org/x/sys@v0.0.0-20201109165425-215b40eba54c/unix/zsyscall_darwin_arm64.go:121:3: //go:linkname must refer to declared function or variable
/Users/jpeach/go/pkg/mod/golang.org/x/sys@v0.0.0-20201109165425-215b40eba54c/unix/zsyscall_darwin_arm64.go:121:3: too many errors
make: *** [hack/tools/openshift-goimports-b92214262c6ce8598aefdee87aae6b8cf1a9fc86] Error 2

I think that if we switch to the tools pattern, I think that we can resolve this.

https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module

[ncdc]

What go version are you using?

[ncdc]

We based the current setup on kubernetes-sigs/cluster-api#5569 (also see the referenced Slack thread in there).

[jpeach]

What go version are you using?

1.18 on macOS M1. The problem is that the imports tool has a golang.org/x/sys that is too old.

[jpeach]

We based the current setup on kubernetes-sigs/cluster-api#5569 (also see the referenced Slack thread in there).

Yeh hard to tell from that thread what problems they had. Maybe module dependency hell?

[vincepri](https://app.slack.com/team/UCD11GCET)  [6 months ago](https://kubernetes.slack.com/archives/C8TSNPY4T/p1635448081211400?thread_ts=1635440307.207400&cid=C8TSNPY4T)
Kustomize brings in lots of go mod dependencies, that's why we moved away from it

[ncdc]

Are you able to downgrade to go 1.17? Because kcp is based on internals of Kubernetes, it's easiest for us to match the go version that Kubernetes is using.

[ncdc]

Or hopefully the openshift-goimports PR will fix things

[jpeach]

Or hopefully the openshift-goimports PR will fix things

yeh, let's upgrade when that lands

[ncdc]

@jpeach we fixed the test infra to get your openshift-goimports PR to merge. Would you be willing to update kcp to use the latest commit from https://github.com/openshift-eng/openshift-goimports in the Makefile?