-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install external hack/tools with a temporary go module #5569
Comments
/area code-organization |
@sbueringer: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
/milestone v1.2 |
We currently install all our hack/tool's via the hack/tools/go.mod go module. After a discussion in Slack (https://kubernetes.slack.com/archives/C8TSNPY4T/p1635440307207400) the consensus was that we want to install the tools via individual temporary go modules.
An example can be seen in CAPG: https://github.com/kubernetes-sigs/cluster-api-provider-gcp/blob/main/Makefile#L187-L188
Essentially, we ~ need the
./scripts/go_install.sh
script and then the following in our Makefile (example kustomize):I think the following tools can be installed this way:
This helps us to avoid a monolithic hack/tools/go.mod file and after this change it only contains the dependencies of our local hack/tool's
Also this helps to make the version of our dependencies visible top-level (in the Makefile instead of hack/tools/go.mod)
/kind feature
The text was updated successfully, but these errors were encountered: