✨ add a new field that reports errors in case resource was incompatible

[rahulii]

Summary

This PR add a new field that reports incompatibility errors!

Related issue(s)

Fixes kcp-dev/contrib-tmc#33

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS
• config/crds/OWNERS
• sdk/apis/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @rahulii. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rahulii]

cc: @davidfestal

[stevekuznetsov]

/ok-to-test

[stevekuznetsov]

If an end-to-end test already exists for this case, can we check that message is set how we expect there?

[rahulii]

If an end-to-end test already exists for this case, can we check that message is set how we expect there?

@stevekuznetsov where are the e2e tests located?

[rahulii]

/retest

[openshift-ci]

@rahulii: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/codegen	8ec6949	link	true	/test codegen
ci/prow/test	8ec6949	link	true	/test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[davidfestal]

@rahulii You should be able to add the comparison of the message in the following e2e test:

kcp/test/e2e/reconciler/locationworkspace/synctarget_test.go

Lines 118 to 124 in 24b8050

	if syncTarget.Status.SyncedResources[0].Resource != "cowboys" ||
	syncTarget.Status.SyncedResources[0].State != workloadv1alpha1.ResourceSchemaIncompatibleState {
	return false
	}
	return true
	}, wait.ForeverTestTimeout, time.Millisecond*100)

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kcp-ci-bot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mjudeikis]

/close
TMC related

[kcp-ci-bot]

@mjudeikis: Closed this PR.

In response to this:

/close
TMC related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.