Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add missing LoggingBetaOptions flag #2969

Merged
merged 1 commit into from
Jun 6, 2023
Merged

🐛 Add missing LoggingBetaOptions flag #2969

merged 1 commit into from
Jun 6, 2023

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Jun 3, 2023 •
edited
Loading

Summary

Fixes failure to start when in the "real world" aka panics with flag not registered :)

Related issue(s)

Fixes #

@sttts
Copy link
Member

sttts commented Jun 4, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2023
@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis mjudeikis closed this Jun 5, 2023
@mjudeikis mjudeikis reopened this Jun 5, 2023
@mjudeikis
Copy link
Contributor Author

/test e2e-sharded

@mjudeikis
Copy link
Contributor Author

/refresh

@xrstf
Copy link
Contributor

xrstf commented Jun 5, 2023

/retest

@mjudeikis mjudeikis closed this Jun 6, 2023
@mjudeikis mjudeikis reopened this Jun 6, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@mjudeikis
Copy link
Contributor Author

/test e2e

1 similar comment
@mjudeikis
Copy link
Contributor Author

/test e2e

@xrstf
Copy link
Contributor

xrstf commented Jun 6, 2023

/test all

@xrstf
Copy link
Contributor

xrstf commented Jun 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@xrstf
Copy link
Contributor

xrstf commented Jun 6, 2023

/retest

tide pls

@mjudeikis
Copy link
Contributor Author

/goose

@xrstf
Copy link
Contributor

xrstf commented Jun 6, 2023

/retest

1 similar comment
@xrstf
Copy link
Contributor

xrstf commented Jun 6, 2023

/retest

@xrstf
Copy link
Contributor

xrstf commented Jun 6, 2023

/test all

Say hello to kcp-prow!

@xrstf xrstf closed this Jun 6, 2023
@xrstf xrstf reopened this Jun 6, 2023
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xrstf
Copy link
Contributor

xrstf commented Jun 6, 2023

/test all

@mjudeikis
Copy link
Contributor Author

/honk

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@mjudeikis:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot merged commit d577569 into kcp-dev:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xrstf xrstf

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjudeikis @sttts @xrstf @kcp-ci-bot