-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Protect APIBindings created during workspace initialization #3092
✨ Protect APIBindings created during workspace initialization #3092
Conversation
…tion of ws Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Skipping CI for Draft Pull Request. |
5b70b3d
to
0901e2d
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I feel like this is missing something, or is there magic around |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. /close |
@kcp-ci-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
The APIBindings created during workspace initialization should not be updated or deleted by users as no controller reconciles those. Once they are updated or deleted, no lifecycle happens for those APIBindings.
This creates inconsistencies in the system as there is no guarantee that APIBindings listed in
WorkspaceType.spec.defaultAPIBindings
would be honored across the lifecycle of the workspace.Release Notes