Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ split go releaser archives #3106

Merged
merged 2 commits into from
Aug 17, 2024
Merged

✨ split go releaser archives #3106

merged 2 commits into from
Aug 17, 2024

Conversation

mjudeikis
Copy link
Contributor

Summary

Release file copies, and not softlink'ed one. Go release does not know how to handle those

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2024
@mjudeikis mjudeikis changed the title ✨ cp files over symlinks ✨ split go releaser archives Mar 31, 2024
@mjudeikis
reorder goreleaser files
dbe4881 
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
@embik embik mentioned this pull request May 3, 2024
Open
@kcp-ci-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kcp-ci-bot kcp-ci-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2024
@kcp-ci-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kcp-ci-bot kcp-ci-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 29, 2024
@embik
Copy link
Member

embik commented Aug 2, 2024 •
edited

I've been thinking about this for a while and I wonder if it's the wrong approach to the problem that we can only ship one binary via krew.

Why don't we reduce or plugins to a single one, kubectl-kcp? kubectl-workspace is also available as a subcommand in kubectl-kcp anyway. To get kubectl workspace and kubectl ws, we could instead instruct users to create handy aliases. Alternatively, we could also instruct them to create symlinks and let kubectl-kcp do different things depending on the name under which it is called.

WDYT?

@embik
Copy link
Member

embik commented Aug 2, 2024

/remove-lifecycle rotten

@kcp-ci-bot kcp-ci-bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 2, 2024
@sttts
Copy link
Member

sttts commented Aug 17, 2024

Why don't we reduce or plugins to a single one

That breaks down with kubectl create workspace, xref #3154.

From all the commands kubectl ws is what I use by far most often. IMO it deserves to be its own command.

@sttts
Copy link
Member

sttts commented Aug 17, 2024

This stops the bleeding.

Follow-up #3154.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 75c498ef5144343de43d508236d686bc82f4e2b6

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2024
@kcp-ci-bot kcp-ci-bot merged commit bbe3354 into kcp-dev:main Aug 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mjudeikis @kcp-ci-bot @embik @sttts