Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Use --update-aliases on mike deploy correctly #3126

Merged
merged 1 commit into from
May 7, 2024

Conversation

embik
Copy link
Member

@embik embik commented May 7, 2024

Summary

I misunderstood the --update-aliases flag on mike deploy, which resulted in https://github.com/kcp-dev/kcp/actions/runs/8986885214/job/24684080310:

+ mike deploy --push --update-aliases v0.24 latest v0.24
error: duplicated version and alias

This PR adjusts the docs deploy script as necessary so it runs the command as intended, something like this:

mike deploy --push --update-aliases v0.24 latest

Also see https://github.com/jimporter/mike?tab=readme-ov-file#building-your-docs.

Related issue(s)

Fixes #

Release Notes

NONE

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels May 7, 2024
@embik
Copy link
Member Author

embik commented May 7, 2024

/cc @xrstf

@kcp-ci-bot kcp-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 7, 2024
@kcp-ci-bot kcp-ci-bot requested a review from xrstf May 7, 2024 14:27
@embik
Copy link
Member Author

embik commented May 7, 2024

/cherry-pick release-0.24

@kcp-ci-bot
Copy link
Contributor

@embik: once the present PR merges, I will cherry-pick it on top of release-0.24 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Member

sttts commented May 7, 2024

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c16bc1a9657b14c0541319f3b66fe6d4ecd7e1d8

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@kcp-ci-bot kcp-ci-bot merged commit 8a34a12 into kcp-dev:main May 7, 2024
14 checks passed
@kcp-ci-bot
Copy link
Contributor

@embik: new pull request created: #3127

In response to this:

/cherry-pick release-0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants