-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Use --update-aliases
on mike deploy
correctly
#3126
Conversation
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
/cc @xrstf |
/cherry-pick release-0.24 |
@embik: once the present PR merges, I will cherry-pick it on top of release-0.24 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: c16bc1a9657b14c0541319f3b66fe6d4ecd7e1d8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@embik: new pull request created: #3127 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
I misunderstood the
--update-aliases
flag onmike deploy
, which resulted in https://github.com/kcp-dev/kcp/actions/runs/8986885214/job/24684080310:This PR adjusts the docs deploy script as necessary so it runs the command as intended, something like this:
Also see https://github.com/jimporter/mike?tab=readme-ov-file#building-your-docs.
Related issue(s)
Fixes #
Release Notes