✨ apis: use logicalcluster.Name in API types #3130
Open
+71
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
…er.Name Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
kcp-ci-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
size/L
sttts
changed the title
|
/lgtm |
|
LGTM label has been added. Git tree hash: 4876cd31ddda42285d1261ee432c452e101327b2
|
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
kcp-ci-bot
added
the
lifecycle/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the field type from
stringtologicalcluster.NameinWorkspace.Spec.ClusterAPIBinding.Status.APIExportClusterNameThese changes do not influence the API, only the Go code.
The main adaption of code is:
logicalcluster.NewPath(ws.Spec.Cluster) => ws.Spec.Cluster.Path().Related issue(s)
Release Notes