-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Inject kcp-start-informers
logger into correct hook context
#3134
Conversation
… server context Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Skipping CI for Draft Pull Request. |
/cc @mjudeikis @xrstf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 905c156049115f6b32ecd76717bb1179533b238c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
I've observed log lines like the one below for quite a while:
Note the double entry
"postStartHook":"kcp-start-informers","postStartHook":"kcp-start-controllers"
.Turns out that in the
kcp-start-informers
post start hook the logger gets injected intoctx
. That's however not the context of the hook, it's the main context used by the whole(s *Server) Run
method! This PR creates a newhookCtx
that is explicitly instantiated within the hook and is subsequently passed to all informers and the server bootstrap code.Note this is relatively low priority and I don't want it to block #3132.
Related issue(s)
Fixes #
Release Notes