Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plumb through github.com/kcp-dev/apimachinery/pkg/logicalcluster.LogicalCluster #53

Merged
merged 3 commits into from
Mar 26, 2022
Merged

Plumb through github.com/kcp-dev/apimachinery/pkg/logicalcluster.LogicalCluster #53

merged 3 commits into from
Mar 26, 2022

Conversation

sttts
Copy link
Member

@sttts sttts commented Mar 18, 2022

  • adding type safety
  • abstract logical cluster retrival from objects (to prepare for deprecation of metadata.clusterName)
  • prepare for switch to path semantics on the higher layers (i.e. open the door for multiple levels for orgs)

@sttts sttts force-pushed the sttts-kcp-logicalcluster branch 4 times, most recently from 9570c92 to 3c45cba Compare March 24, 2022 15:46
@sttts sttts changed the title WIP: Plumb through github.com/kcp-dev/apimachinery/pkg/logicalcluster.LogicalCluster Plumb through github.com/kcp-dev/apimachinery/pkg/logicalcluster.LogicalCluster Mar 25, 2022
@sttts sttts mentioned this pull request Mar 25, 2022
Merged
@sttts sttts force-pushed the sttts-kcp-logicalcluster branch from 3c45cba to f538bbb Compare March 25, 2022 19:24
marun
marun approved these changes Mar 25, 2022
View reviewed changes
Copy link

@marun marun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sttts sttts force-pushed the sttts-kcp-logicalcluster branch from f538bbb to 92f0517 Compare March 25, 2022 20:16
@sttts sttts merged commit 57ce33e into kcp-dev:feature-logical-clusters-1.23 Mar 26, 2022
@sttts sttts deleted the sttts-kcp-logicalcluster branch March 26, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marun marun marun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sttts @marun