Walk thru (#1)

- fixes issues with typescript and node ts types microsoft/TypeScript#51567 (comment) -add chrome pwa debugger - cleanup settings.json file - run npm audit fix
kdcllc · Aug 28, 2023 · 2fec08e · 2fec08e
1 parent bf88f39
commit 2fec08e
Show file tree

Hide file tree

Showing 8 changed files with 157 additions and 110 deletions.
diff --git a/.gitignore b/.gitignore
@@ -6,6 +6,7 @@
 *.user
 *.userosscache
 *.sln.docstates
+wwwroot/
 
 # Build results
 [Dd]ebug/

diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -35,7 +35,26 @@
       "sourceMaps": true,
       "trace": true,
       "preLaunchTask": "npm: dev - src/Web",
-      "postDebugTask": "Close tasks"
+      "postDebugTask": "postdebugKill"
+    },
+
+    {
+        "type": "pwa-chrome",
+        "request": "launch",
+        "name": "Run PWA",
+        "webRoot": "${workspaceFolder}/src/ClientApp",
+        "sourceMaps": true,
+        "trace": true,
+        "url": "http://localhost:5050",
+        // "runtimeArgs": [
+        //     "--app=http://localhost:5050"
+        // ],
+        "sourceMapPathOverrides": {
+            "../../src/ClientApp": "${workspaceFolder}/src/ClientApp",
+            "../../src/ClientApp/*": "${workspaceFolder}/src/ClientApp/*"
+        },
+        "preLaunchTask": "npm run dev-task",
+        "postDebugTask": "postdebugKill"
     }
   ],
 }
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,5 +1,4 @@
 {
-  "version": "2.0.0",
   "editor.formatOnSave": false,
   "editor.tabSize": 4,
   "editor.insertSpaces": true,
@@ -11,39 +10,7 @@
   "[javascript]": {
       "editor.tabSize": 4
   },
-  "tasks": [
-      {
-          "label": "npm run dev-task",
-          "type": "npm",
-          "script": "dev-task",
-          "isBackground": true,
-          "problemMatcher": {
-              "owner": "custom",
-              "pattern": {
-                  "regexp": "^$"
-              },
-              "background": {
-                  "activeOnStart": true,
-                  "beginsPattern": ".*",
-                  "endsPattern": "ready in .+"
-              }
-          },
-      },
-      {
-          "label": "postdebugKill",
-          "command": "echo ${input:terminate}",
-          "type": "shell",
-          "problemMatcher": []
-      },
-  ],
-  "inputs": [
-      {
-          "id": "terminate",
-          "type": "command",
-          "command": "workbench.action.tasks.terminate",
-          "args": "npm run dev-task"
-      }
-  ],
+
   "files.exclude": {
       "**/.git": true,
       "**/.svn": true,
@@ -52,5 +19,13 @@
       "**/.DS_Store": true,
       "**/Thumbs.db": true,
       "**/node_modules": true
-  }
+},
+
+// allow for linux shell
+"terminal.integrated.automationProfile.linux": {
+    "path": "/usr/bin/bash",
+    "args": ["-i"]
+},
+"dotnet.defaultSolution": "MessianicChords.sln"
+
 }
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
@@ -7,7 +7,7 @@
             "path": "src/ClientApp",
             "isBackground": true,
             "label": "npm: install - client",
-            "detail": "npm run intall"
+            "detail": "npm run intall",
         },
         {
             "type": "npm",
@@ -35,7 +35,7 @@
             "detail": "npm run dev-server"
         },
         {
-            "label": "Close tasks",
+            "label": "postdebugKill",
             "command": "echo ${input:terminate}",
             "type": "shell",
             "problemMatcher": []
@@ -57,6 +57,25 @@
             },
             "problemMatcher": "$msCompile"
         },
+
+        {
+            "label": "npm run dev-task",
+            "type": "npm",
+            "script": "dev-task",
+            "path": "src/ClientApp",
+            "isBackground": true,
+            "problemMatcher": {
+                "owner": "custom",
+                "pattern": {
+                    "regexp": "^$"
+                },
+                "background": {
+                    "activeOnStart": true,
+                    "beginsPattern": "vite",
+                    "endsPattern": "ready in"
+                }
+            },
+        },
     ],
     "inputs": [
         {

diff --git a/README.md b/README.md
@@ -1,10 +1,13 @@
 # MessianicChords
+
 This is the source code for MessianicChords.com, the best place to find lyrics and guitar chords for Messianic Jewish music
 
 ## Technologies
+
 We use ASP.NET Core on the server, Lit web components on the client.
 
 ## Running locally
+
 Open the .sln solution file in Visual Studio and hit F5 to run the server. 
 
 Then `cd ClientApp` and run `npm run dev` to run the client.