-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Syntax Highlighting #82
Comments
Will note that GitHub will likely not include a new grammar for a language unless it can be demonstrated that the language is in significant enough usage ("hundreds of repositories").
See below comment re existing TextMate definition. |
I think we have a TextMate definition here, but yes, as far as I am aware more usage is required for GitHub to consider adding it. |
I think KDL does have enough usage now! 2.3k hits for searching for
Any regex pros wanna jump in here? This sequence doesn't seem to be anywhere in the grammar. |
I'm also not entirely sure what license the grammar is under. It needs to be one of these (see github-linguist/linguist/CONTRIBUTING.md#L125). |
Maybe we can fix the grammar issues before 2.0? #285 |
@uncenter The grammar is under Apache-2.0 by virtue of being in the vscode-kdl repo. And yes, it would be nice to fix the grammar issues before 2.0! Although the textmate grammar has to kinda be redone to support 2.0. |
Oh it looks like the fixes already got merged. Still, we should probably wait to pursue syntax highlighting until 2.0 is out. |
as far as that sequence being present, it's in the regex for identifiers: https://github.com/kdl-org/vscode-kdl/blob/main/syntaxes/kdl.tmLanguage.json#L97 I'm not really sure how to work around this. KDL, and especially KDL 2.0, has specific restrictions around unicode codepoints. Does this mean that linguist's PCRE doesn't support unicode matching at all, or is there a different syntax I should be using? |
oh maybe all that needs to be done is to use |
Would be nice to have GitHub identify and add syntax highlighting to KDL-formatted files
https://github.com/github/linguist
The text was updated successfully, but these errors were encountered: