Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the netreach target configuration not taking effect #200

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

ii2day
Copy link
Collaborator

@ii2day ii2day commented Sep 13, 2023

fix #201
修复 netreach 配置target 字段下的 clusterIP nodePort endPoint 等不生效问题。
现象:
yaml中 nodeport 为 false 下发后生成的 cr nodeport 为 true,且执行的任务也是按照 true 去执行,但日志中显示 nodeport 字段为 false。

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #200 (bf1ed3d) into main (bcad019) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   38.94%   38.94%           
=======================================
  Files           8        8           
  Lines         529      529           
=======================================
  Hits          206      206           
  Misses        318      318           
  Partials        5        5           
Flag Coverage Δ
unittests 38.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ii2day ii2day changed the title Fixed the netreach target configuration not taking effect fixed the netreach target configuration not taking effect Sep 13, 2023
@ii2day ii2day force-pushed the fix/ii2day/netreach branch from 74e0429 to dbde671 Compare September 13, 2023 10:40
@weizhoublue
Copy link
Collaborator

weizhoublue commented Sep 14, 2023

(1)不需要重新生成 crd yaml ?
(2)是否有用例覆盖

@ii2day
Copy link
Collaborator Author

ii2day commented Sep 14, 2023

(1)不需要重新生成 crd yaml ? (2)是否有用例覆盖

不需要重新生成 crd
目前还没有用例覆盖

@weizhoublue
Copy link
Collaborator

weizhoublue commented Sep 27, 2023

(1)我还是不明白 这个 comment

kubebuilder:validation:Optional
specifies that this field is optional, if fields are required by default

如果原来未加,是 required by default, 此时变为了 validation:Optional ,不需要重新生成 CRD 定义么

(2)没有 用例 闭环这个验证 ?

@ii2day ii2day force-pushed the fix/ii2day/netreach branch 2 times, most recently from 15f7e57 to eb2faa1 Compare September 28, 2023 03:07
@ii2day
Copy link
Collaborator Author

ii2day commented Sep 28, 2023

(1)我还是不明白 这个 comment

kubebuilder:validation:Optional specifies that this field is optional, if fields are required by default

如果原来未加,是 required by default, 此时变为了 validation:Optional ,不需要重新生成 CRD 定义么

(2)没有 用例 闭环这个验证 ?

用例已添加
使用 make update crd 了,运行完并没有修改

@ii2day ii2day force-pushed the fix/ii2day/netreach branch from eb2faa1 to 4bd5440 Compare September 28, 2023 06:41
@ii2day ii2day force-pushed the fix/ii2day/netreach branch 3 times, most recently from 847af1a to 3e71bc4 Compare October 9, 2023 07:14
Signed-off-by: ii2day <ji.li@daocloud.io>
@ii2day ii2day force-pushed the fix/ii2day/netreach branch from 3e71bc4 to bf1ed3d Compare October 9, 2023 07:17
@weizhoublue weizhoublue merged commit 32ca339 into main Oct 9, 2023
22 checks passed
@weizhoublue weizhoublue deleted the fix/ii2day/netreach branch October 9, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

software bug netreach target configuration not taking effect
2 participants