-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed the netreach target configuration not taking effect #200
Conversation
5303d4a
to
74e0429
Compare
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 38.94% 38.94%
=======================================
Files 8 8
Lines 529 529
=======================================
Hits 206 206
Misses 318 318
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. |
74e0429
to
dbde671
Compare
(1)不需要重新生成 crd yaml ? |
不需要重新生成 crd |
(1)我还是不明白 这个 comment kubebuilder:validation:Optional 如果原来未加,是 required by default, 此时变为了 validation:Optional ,不需要重新生成 CRD 定义么 (2)没有 用例 闭环这个验证 ? |
15f7e57
to
eb2faa1
Compare
用例已添加 |
eb2faa1
to
4bd5440
Compare
847af1a
to
3e71bc4
Compare
Signed-off-by: ii2day <ji.li@daocloud.io>
3e71bc4
to
bf1ed3d
Compare
fix #201
修复 netreach 配置target 字段下的 clusterIP nodePort endPoint 等不生效问题。
现象:
yaml中 nodeport 为 false 下发后生成的 cr nodeport 为 true,且执行的任务也是按照 true 去执行,但日志中显示 nodeport 字段为 false。