reuse workload #245
Merged
reuse workload #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 38.94% 39.16% +0.22%
==========================================
Files 8 8
Lines 529 526 -3
==========================================
Hits 206 206
+ Misses 318 315 -3
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ii2day
force-pushed
the
feat/ii2day/reuse_workload
branch
2 times, most recently
from
9f06e2f to
bcd755e
Compare
ii2day
force-pushed
the
feat/ii2day/reuse_workload
branch
5 times, most recently
from
fe567a7 to
ade9eb8
Compare
ii2day
force-pushed
the
feat/ii2day/reuse_workload
branch
2 times, most recently
from
dab2193 to
1936ab1
Compare
weizhoublue
reviewed
Oct 16, 2023
| @@ -59,10 +59,6 @@ spec: | |||
| spec: | |||
| properties: | |||
| agentSpec: | |||
| default: | |||
There was a problem hiding this comment.
这个feature 对 原理的新建逻辑 为什么有修改
There was a problem hiding this comment.
这个 feature 如果不填写 agentSpec 使用默认的 agent 执行任务，所以将原 agent 改为指针类型，原有的 agent 存在 默认值，会导致无论怎么做都有 agentspec 字段，这个默认值 只是 agentspec 的默认值，不是 agentspec里字段的默认值
weizhoublue
reviewed
Oct 16, 2023
charts/templates/deployment.yaml
Outdated
| - name: ENV_GENERAL_AGENT_TYPE | ||
| value: DaemonSet | ||
| {{- if .Values.feature.enableIPv4 }} | ||
| - name: ENV_GENERAL_AGENT_SERVICE_V4_NAME |
There was a problem hiding this comment.
这些都是只为default agent ？ 建议都加上 default agent 字眼
weizhoublue
reviewed
Oct 16, 2023
cmd/agent/cmd/config.go
Outdated
| @@ -76,6 +76,7 @@ func init() { | |||
| globalFlag.StringVar(&types.AgentConfig.ServiceV6Name, "service-ipv6-name", "", "agent IPv6 service name") | |||
|
|
|||
| globalFlag.BoolVarP(&types.AgentConfig.AppMode, "app-mode", "A", false, "app mode") | |||
| globalFlag.BoolVarP(&types.AgentConfig.GeneralAgent, "general-agent", "G", false, "general agent") | |||
ii2day
force-pushed
the
feat/ii2day/reuse_workload
branch
3 times, most recently
from
b5f2a7c to
2fc086c
Compare
Signed-off-by: ii2day <ji.li@daocloud.io>
ii2day
force-pushed
the
feat/ii2day/reuse_workload
branch
from
2fc086c to
aa3e95f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature #204
实现复用 daemonset 作为 workload
若 task 未定义 agentSpec 字段，controller 使用默认的 daemonset 执行任务。
若 task 定义了 agentSpec 字段，controller 创建新的 workload 执行任务。