Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#303]fix-Failed_to_get_the_dns_service_IP_list #306

Merged

Conversation

carryaimp
Copy link
Contributor

  1. Added the logic for determining whether the obtained DNS IP address list is empty
  2. Get and set the label of the default selected DNS service through the environment variable

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #306 (8ea6517) into main (8f17d25) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   40.00%   40.00%           
=======================================
  Files           8        8           
  Lines         555      555           
=======================================
  Hits          222      222           
  Misses        326      326           
  Partials        7        7           
Flag Coverage Δ
unittests 40.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ii2day
Copy link
Collaborator

ii2day commented Nov 6, 2023

@carryaimp We have a special method to obtain env environment variables. Refer to this file to set env.https://github.com/kdoctor-io/kdoctor/blob/main/pkg/types/agent_config.go

@carryaimp carryaimp force-pushed the fix-list_dns_serviceip_failed branch from 51a6347 to a533252 Compare November 6, 2023 06:43
@carryaimp
Copy link
Contributor Author

@ii2day It has been modified according to the specifications

pkg/types/agent_config.go Outdated Show resolved Hide resolved
@carryaimp carryaimp force-pushed the fix-list_dns_serviceip_failed branch from c24baf3 to 8ea6517 Compare November 6, 2023 07:08
@ii2day
Copy link
Collaborator

ii2day commented Nov 6, 2023

@weizhoublue lgtm

@weizhoublue weizhoublue merged commit 7825f93 into kdoctor-io:main Nov 6, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants