use new dns client to fix data race and reuse connect #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
原 pr 代码推送上来后，分支有更新，但是 pr 没有更新，怀疑遇到了 github 的bug，因此重新开启新的 pr |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
==========================================
+ Coverage 80.73% 81.07% +0.34%
==========================================
Files 22 22
Lines 1557 1596 +39
==========================================
+ Hits 1257 1294 +37
- Misses 223 224 +1
- Partials 77 78 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ii2day
force-pushed
the
main
branch
2 times, most recently
from
f515cf9 to
05f7c79
Compare
ii2day
commented
Nov 21, 2023
| @@ -779,7 +779,7 @@ var _ = Describe("testing appHttpHealth test ", Label("appHttpHealth"), func() { | |||
| Expect(e).NotTo(HaveOccurred(), "check task runtime resource delete") | |||
| }) | |||
|
|
|||
| It("Successfully testing using default daemonSet as workload with Task AppHttpHealthy ", Label("E00014"), func() { | |||
| It("Successfully testing using default daemonSet as workload with Task AppHttpHealthy ", Pending, Label("E00014"), func() { | |||
There was a problem hiding this comment.
default agent 的几个用例，有时会出现 oom 的情况，需要重新调整用例，以及查找 oom 的原因，暂时先 pending 下。
There was a problem hiding this comment.
增加了 limit 数值，未现 oom 了
ii2day
force-pushed
the
main
branch
7 times, most recently
from
6eb01a8 to
3e9242b
Compare
ii2day
commented
Nov 22, 2023
| @@ -14,8 +14,8 @@ import ( | |||
|
|
|||
| var _ = Describe("testing netReach ", Label("netReach"), func() { | |||
| var termMin = int64(1) | |||
| // 1000ms is not stable on GitHub ci, so increased to 3000ms | |||
| var requestTimeout = 3000 | |||
There was a problem hiding this comment.
ci 机器上的延时有些高，因此调整到 6000 .
ii2day
force-pushed
the
main
branch
7 times, most recently
from
1f2b5e1 to
9543d94
Compare
Signed-off-by: ii2day <ji.li@daocloud.io>
This was referenced Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.原方法在使用 udp 协议复用连接时，因为 msg id 问题，返回会被抛弃，通过更改连接复用的使用方式，达到复用连接时不丢弃消息，同时因 tcp 协议在服务端会存在连接时长过长问题被动断开连接，因此 tcp 协议不进行连接复用。
2.e2e 资源 limit 增加
3. e2e 增加延迟数值
fix #298
fix #305