Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns client udp connect read and write will not time out #347

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

ii2day
Copy link
Collaborator

@ii2day ii2day commented Nov 23, 2023

1.dns client 的 udp 连接不设置 write 和 read 的超时时间,当遇见响应较慢的服务时,最后的请求会超过 deadline时间,导致请求失败
2.防止最后的请求因延迟过高,无法得到返回,添加等待时间,等待最后的返回。

@ii2day ii2day requested a review from weizhoublue as a code owner November 23, 2023 03:22
@ii2day ii2day added bug Something isn't working release/bug and removed bug Something isn't working labels Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #347 (e06b019) into main (1d0ff20) will decrease coverage by 0.64%.
The diff coverage is 45.45%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   81.07%   80.44%   -0.64%     
==========================================
  Files          22       22              
  Lines        1596     1611      +15     
==========================================
+ Hits         1294     1296       +2     
- Misses        224      235      +11     
- Partials       78       80       +2     
Flag Coverage Δ
unittests 80.44% <45.45%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/loadRequest/loadHttp/http_requester.go 86.91% <100.00%> (+0.18%) ⬆️
pkg/loadRequest/loadDns/dns_requester.go 82.26% <36.84%> (-5.17%) ⬇️

... and 1 file with indirect coverage changes

@ii2day ii2day force-pushed the main branch 8 times, most recently from 080443b to c842e42 Compare November 23, 2023 10:38
Signed-off-by: ii2day <ji.li@daocloud.io>
@weizhoublue weizhoublue merged commit c1e06d3 into kdoctor-io:main Nov 23, 2023
21 of 22 checks passed
This was referenced Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants